Skip to content

Don't set up full filesystem to check for certificates #31360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
PVince81 merged 1 commit into from
Feb 28, 2022
Merged

Don't set up full filesystem to check for certificates #31360

PVince81 merged 1 commit into from
Feb 28, 2022

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Feb 25, 2022

Ref:

server/lib/private/Security/CertificateManager.php

Lines 90 to 93 in 215aef3

$path = $this->getPathToCertificates() . 'uploads/';
if (!$this->view->is_dir($path)) {
return [];
}

Case

  • Set up Talk with HPB
  • Join a call => sends HPB message to inform all users => sets up your FS

@nickvergessen nickvergessen added this to the Nextcloud 24 milestone Feb 25, 2022
CarlSchwan
CarlSchwan approved these changes Feb 25, 2022
View reviewed changes
Copy link
Member

@CarlSchwan CarlSchwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense 👍

@nickvergessen nickvergessen mentioned this pull request Feb 25, 2022
Merged
1 task
@nickvergessen nickvergessen force-pushed the techdebt/noid/also-skip-user-setup-when-getting-certificates branch from a0fd5d0 to 88f4e97 Compare February 25, 2022 23:40
@nickvergessen nickvergessen mentioned this pull request Feb 25, 2022
Merged
PVince81
PVince81 approved these changes Feb 28, 2022
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit 3bae591 into master Feb 28, 2022
@PVince81 PVince81 deleted the techdebt/noid/also-skip-user-setup-when-getting-certificates branch February 28, 2022 08:20
@nickvergessen
Copy link
Member Author

nickvergessen commented Mar 1, 2022

/backport to stable23

@nickvergessen
Copy link
Member Author

nickvergessen commented Mar 1, 2022 •
edited
Loading

Could backport to 22 as well when the backport of icewind's PR (#31099) is merged

@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Mar 1, 2022

The backport to stable23 failed. Please do this backport manually.

@nickvergessen
Copy link
Member Author

nickvergessen commented Mar 2, 2022

/backport to stable23

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Mar 2, 2022
Merged
@nickvergessen nickvergessen mentioned this pull request Mar 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PVince81 PVince81 PVince81 approved these changes

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees

No one assigned

Labels

3. to review Waiting for reviews bug feature: filesystem performance 🚀

Projects

None yet

Milestone

Nextcloud 24

Development

Successfully merging this pull request may close these issues.

4 participants

@nickvergessen @PVince81 @CarlSchwan