[stable23] Run tests with primary object storage in CI + large upload fixes #31453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PVince81
changed the title
PVince81
reviewed
Mar 4, 2022
| ]; | ||
| } else { | ||
| return null; | ||
| return [ |
Member
There was a problem hiding this comment.
also backporting behavior changes?
Member
Author
There was a problem hiding this comment.
As far as I can tell the previous behavior has never hit, as none of the code paths handle the null case.
PVince81
reviewed
Mar 4, 2022
PVince81
changed the title
szaimen
reviewed
Mar 8, 2022
| env: | ||
| MINIO_ACCESS_KEY: minio | ||
| MINIO_SECRET_KEY: minio123 | ||
| image: bitnami/minio:2021.10.6 |
Contributor
There was a problem hiding this comment.
could this run into limits due to the new docker hub policy?
Member
|
/rebase |
Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
…torage Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
…g part files Signed-off-by: Robin Appelman <[email protected]>
nextcloud-command
force-pushed
the
s3-primary-ci-23
branch
from
ef8bc9e to
b05c9fe
Compare
Merged
blizzz
approved these changes
Apr 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of test changes from #31266