Skip to content

Conversation

@Pytal
Copy link
Member

@Pytal Pytal commented Mar 8, 2022

Required for #31382

To Do

  • Update test

Before

{
  "displayname": {
    "name": "displayname",
    "value": "admin",
    "scope": "v2-federated",
    "verified": "0",
    "verificationData": ""
  },
  ...
  "additional_mail": {
    "additional_mail": [
      {
        "name": "additional_mail",
        "value": "[email protected]",
        "scope": "v2-local",
        "verified": "0",
        "verificationData": ""
      },
      {
        "name": "additional_mail",
        "value": "[email protected]",
        "scope": "v2-local",
        "verified": "0",
        "verificationData": ""
      }
    ]
  }
}

After

{
  "displayname": {
    "name": "displayname",
    "value": "admin",
    "scope": "v2-federated",
    "verified": "0",
    "verificationData": ""
  },
  ...
  "additional_mail": [
    {
      "name": "additional_mail",
      "value": "[email protected]",
      "scope": "v2-local",
      "verified": "0",
      "verificationData": ""
    },
    {
      "name": "additional_mail",
      "value": "[email protected]",
      "scope": "v2-local",
      "verified": "0",
      "verificationData": ""
    }
  ]
}

@Pytal Pytal added enhancement 3. to review Waiting for reviews labels Mar 8, 2022
@Pytal Pytal added this to the Nextcloud 24 milestone Mar 8, 2022
@Pytal Pytal requested review from a team, blizzz and come-nc March 8, 2022 00:42
@Pytal Pytal self-assigned this Mar 8, 2022
@Pytal Pytal requested review from icewind1991 and removed request for a team March 8, 2022 00:42
@Pytal Pytal mentioned this pull request Mar 8, 2022
5 tasks
@Pytal Pytal force-pushed the enh/account-json-serialization branch from 6a27f43 to 0b76a25 Compare March 8, 2022 00:44
@Pytal Pytal force-pushed the enh/account-json-serialization branch from 0b76a25 to 9fb419d Compare March 8, 2022 01:06
@Pytal Pytal requested review from a team, CarlSchwan and artonge March 15, 2022 16:36
@Pytal Pytal force-pushed the enh/account-json-serialization branch 2 times, most recently from 0dee3d0 to a99d33c Compare March 17, 2022 04:28
@blizzz blizzz added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 17, 2022
@Pytal
Copy link
Member Author

Pytal commented Mar 17, 2022

CI failure unrelated

@Pytal Pytal merged commit 2a75c30 into master Mar 17, 2022
@Pytal Pytal deleted the enh/account-json-serialization branch March 17, 2022 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants