Skip to content

Fix duplicated UUID detection when there are empty uuids #31491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
come-nc merged 2 commits into from
Mar 10, 2022
Merged

Fix duplicated UUID detection when there are empty uuids #31491

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
65a8665
Fix duplicated UUID detection when there are empty uuids
come-nc Mar 8, 2022
ccab35f
Fix similar potential problems with fetchOne loops
come-nc Mar 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix duplicated UUID detection when there are empty uuids 
Signed-off-by: Côme Chilliet <[email protected]>
  • Loading branch information
@come-nc
come-nc committed Mar 8, 2022
commit 65a866556bf871f98ab6486dd104e758c06f039b
2 changes: 1 addition & 1 deletion apps/user_ldap/lib/Migration/Version1130Date20211102154716.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,7 @@ protected function getDuplicatedUuids(string $table): Generator {
->having($select->expr()->gt($select->func()->count('owncloud_name'), $select->createNamedParameter(1)));

$result = $select->executeQuery();
while ($uuid = $result->fetchOne()) {
while (($uuid = $result->fetchOne()) !== false) {
yield $uuid;
}
$result->closeCursor();
Expand Down