AmazonS3: allow not implemented versioning #31498
Conversation
|
We're debating whether to change this on Storj side instead. |
|
We would like for you to consider this change. |
CarlSchwan
left a comment
CarlSchwan
left a comment
There was a problem hiding this comment.
The code looks good, but I don't have a Storj gateway to test it
You can sign up for free and get credentials for the Storj-hosted gateway. Alternatively I can DM you credentials. We also have a few ways to set up a local independent network but that is a bit more involved. One option is https://github.com/storj/up, includes gateway-mt (multitent) but not gateway-st which you could add from https://hub.docker.com/r/storjlabs/gateway. Other option is https://github.com/storj/storj/wiki/Test-network, maybe easier. |
|
Code looks good, but I did not test it. It only adds a try/catch, so it should be safe to merge. @Erikvv I assume that you tested it on your server with your storj gateway? |
I have tested it with storj/gateway-st and I'm now able to list and download objects. On upload there is the error #26544 but I haven't looked into this further. I know that it worked last year though. |
|
S3 test failed but error seems unrelated, S3 server seemed down. |
In case the S3 implementation does not implement versioning, set it to false. Versioning was introduced in Nexcloud in commit 09ffac5 This is needed for compatibility with the Storj gateway. Signed-off-by: Erik van Velzen <[email protected]>
|
All green, merging :) |
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
|
Thanks for this @Erikvv ! :) |
|
/backport to stable23 |
|
/backport to stable22 |
|
/backport to stable21 |
|
The backport to stable23 failed. Please do this backport manually. |
|
The backport to stable21 failed. Please do this backport manually. |
|
The backport to stable22 failed. Please do this backport manually. |
6 participants
In case the S3 implementation does not implement versioning, set it to
false. Versioning was introduced in Nexcloud in commit
09ffac5
This is needed for compatibility with the Storj gateway.