Fix occ user:add-app-password #31519
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n app password Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
requested review from
CarlSchwan,
ChristophWurst,
PVince81,
SMillerDev,
julien-nc and
vitormattos
PVince81
reviewed
Mar 10, 2022
SMillerDev
reviewed
Mar 10, 2022
Contributor
SMillerDev
left a comment
SMillerDev
left a comment
There was a problem hiding this comment.
LGTM but then I thought the original implementation was fine too 😅
Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
force-pushed
the
bugfix/noid/fix-occ-user-add-apppassword
branch
from
137b633 to
50ccf7e
Compare
CarlSchwan
approved these changes
Mar 10, 2022
Member
|
/backport to stable23 |
Member
|
/backport to stable22 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps
Create an app-password via all 3 methods and check the differences: