Skip to content

[stable22] Fix duplicated UUID detection when there are empty uuids #31522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blizzz merged 2 commits into from
Apr 14, 2022
Merged

[stable22] Fix duplicated UUID detection when there are empty uuids #31522

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1bb981a
Fix duplicated UUID detection when there are empty uuids
come-nc Mar 8, 2022
503b742
Fix similar potential problems with fetchOne loops
come-nc Mar 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix duplicated UUID detection when there are empty uuids 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
  • Loading branch information
@come-nc @backportbot
come-nc authored and backportbot[bot] committed Mar 10, 2022
commit 1bb981abd6fbedd696e017cc8caea7c5b85902de
2 changes: 1 addition & 1 deletion apps/user_ldap/lib/Migration/Version1130Date20211102154716.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,7 @@ protected function getDuplicatedUuids(string $table): Generator {
->having($select->expr()->gt($select->func()->count('owncloud_name'), $select->createNamedParameter(1)));

$result = $select->executeQuery();
while ($uuid = $result->fetchOne()) {
while (($uuid = $result->fetchOne()) !== false) {
yield $uuid;
}
$result->closeCursor();
Expand Down