Fix passing null to strlen #31655
Merged
Fix passing null to strlen #31655
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcitworld
requested review from
a team,
come-nc,
juliusknorr and
skjnldsv
and removed request for
a team
tcitworld
force-pushed
the
fix-passing-null-to-strlen
branch
from
e06d7cd to
af2dffe
Compare
juliusknorr
approved these changes
Mar 22, 2022
come-nc
reviewed
Mar 22, 2022
tcitworld
force-pushed
the
fix-passing-null-to-strlen
branch
from
af2dffe to
773f69c
Compare
come-nc
approved these changes
Mar 22, 2022
Contributor
|
/rebase |
$filter can be null as it's the default value passed in ContactsMenuController. On PHP 8.1 : strlen(): Passing null to parameter #1 ($string) of type string is deprecated Signed-off-by: Thomas Citharel <[email protected]>
nextcloud-command
force-pushed
the
fix-passing-null-to-strlen
branch
from
773f69c to
0456f61
Compare
Contributor
|
I guess no backport since 23 is not allowing PHP>8.0? |
come-nc
added
4. to release
Member
Author
There's no PHP 8.0 specific code here. 🤔 The fusion null operator is here since PHP 7. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$filtercan be null as it's the default value passed in ContactsMenuController.On PHP 8.1: