Skip to content

Modernize contacts menu backend #31662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
skjnldsv merged 1 commit into from
May 13, 2022
Merged

Modernize contacts menu backend #31662

skjnldsv merged 1 commit into from
May 13, 2022

Conversation

@tcitworld
Copy link
Member

@tcitworld tcitworld commented Mar 22, 2022

The only signature changes due to added types in OCP shouldn't break anything as all apps that I could find only use the IActionFactory methods which are already typed.

@tcitworld tcitworld added 3. to review Waiting for reviews technical debt feature: contacts menu php Pull requests that update Php code labels Mar 22, 2022
@tcitworld tcitworld added this to the Nextcloud 24 milestone Mar 22, 2022
@tcitworld tcitworld force-pushed the modernize-contactmenu branch 2 times, most recently from a59cff2 to 3705459 Compare March 22, 2022 12:16
nickvergessen
nickvergessen reviewed Mar 22, 2022
View reviewed changes
nickvergessen
nickvergessen reviewed Mar 22, 2022
View reviewed changes
nickvergessen
nickvergessen reviewed Mar 22, 2022
View reviewed changes
nickvergessen
nickvergessen reviewed Mar 22, 2022
View reviewed changes
Pytal
Pytal reviewed Mar 22, 2022
View reviewed changes
@skjnldsv skjnldsv mentioned this pull request Mar 24, 2022
Merged
@tcitworld tcitworld force-pushed the modernize-contactmenu branch 2 times, most recently from 6d178df to 9bd0e19 Compare March 24, 2022 17:36
Pytal
Pytal reviewed Mar 24, 2022
View reviewed changes
@blizzz blizzz mentioned this pull request Mar 31, 2022
Merged
@tcitworld tcitworld force-pushed the modernize-contactmenu branch 2 times, most recently from 0b468a1 to b76cd48 Compare April 3, 2022 16:06
@tcitworld tcitworld requested a review from Pytal April 3, 2022 16:11
@tcitworld tcitworld changed the title Modernize contacts menu Modernize contacts menu backend Apr 3, 2022
Pytal
Pytal reviewed Apr 5, 2022
View reviewed changes
This was referenced Apr 7, 2022
Merged
Merged
@blizzz blizzz removed this from the Nextcloud 24 milestone Apr 21, 2022
@blizzz blizzz added this to the Nextcloud 25 milestone Apr 21, 2022
@tcitworld
Modernize contacts menu
232322f 
Signed-off-by: Thomas Citharel <[email protected]>
@tcitworld tcitworld force-pushed the modernize-contactmenu branch from b76cd48 to 232322f Compare May 12, 2022 16:32
@tcitworld tcitworld requested a review from Pytal May 12, 2022 16:32
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 13, 2022
@skjnldsv skjnldsv merged commit 85758a4 into master May 13, 2022
@skjnldsv skjnldsv deleted the modernize-contactmenu branch May 13, 2022 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@Pytal Pytal Awaiting requested review from Pytal

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish feature: contacts menu php Pull requests that update Php code technical debt

Projects

None yet

Milestone

Nextcloud 25

Development

Successfully merging this pull request may close these issues.

7 participants

@tcitworld @nickvergessen @ChristophWurst @skjnldsv @Pytal @blizzz