Skip to content

limit ldap_dn columns to 4000 #31683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
come-nc merged 5 commits into from
Mar 30, 2022
Merged

limit ldap_dn columns to 4000 #31683

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2f49f4a
limit ldap_dn columns to 4000
blizzz Mar 23, 2022
52b57eb
shrink ldap_dn column to 4000
blizzz Mar 23, 2022
6c7ba01
Adapt max length limit in AbstactMapping to match database
come-nc Mar 29, 2022
d07208b
Use the new octetLength function to filter lines to migrate
come-nc Mar 29, 2022
07ab258
Build autoloaders
come-nc Mar 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use the new octetLength function to filter lines to migrate 
Signed-off-by: Côme Chilliet <[email protected]>
  • Loading branch information
@come-nc
come-nc committed Mar 30, 2022
commit d07208bd2cc10e09b4e8136c90c71bd331c1d80e
12 changes: 4 additions & 8 deletions apps/user_ldap/lib/Migration/Version1141Date20220323143801.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,19 +48,15 @@ public function __construct(IDBConnection $dbc) {
*/
public function preSchemaChange(IOutput $output, Closure $schemaClosure, array $options): void {
foreach (['ldap_user_mapping', 'ldap_group_mapping'] as $tableName) {
$dnsTooLong = [];
$lengthExpr = $this->dbc->getDatabasePlatform()->getLengthExpression('ldap_dn');

$qb = $this->dbc->getQueryBuilder();
$qb->select('ldap_dn')
->from($tableName)
->where($qb->expr()->gt($qb->createFunction($lengthExpr), '255', IQueryBuilder::PARAM_INT));
->where($qb->expr()->gt($qb->func()->octetLength('ldap_dn'), '4000', IQueryBuilder::PARAM_INT));

$dnsTooLong = [];
$result = $qb->executeQuery();
while(($dn = $result->fetchOne()) !== false) {
if(mb_strlen($dn) > 4000) {
$dnsTooLong[] = $dn;
}
while (($dn = $result->fetchOne()) !== false) {
$dnsTooLong[] = $dn;
}
$result->closeCursor();
$this->shortenDNs($dnsTooLong, $tableName);
Expand Down