take permissions from multiple paths into account for share permissions #31684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pytal
approved these changes
Mar 23, 2022
Member
|
Backport? |
ArtificialOwl
approved these changes
Mar 23, 2022
Merged
icewind1991
force-pushed
the
user-share-permissions-merge
branch
from
8c949a4 to
3a049c2
Compare
szaimen
added
2. developing
Contributor
|
Test failures... |
Merged
Member
Author
|
/backport to stable23 |
icewind1991
force-pushed
the
user-share-permissions-merge
branch
2 times, most recently
from
417d2fb to
eb9600a
Compare
Signed-off-by: Robin Appelman <[email protected]>
icewind1991
force-pushed
the
user-share-permissions-merge
branch
from
eb9600a to
278b131
Compare
Member
Author
|
Fixed tests |
szaimen
added
3. to review
Merged
Member
|
@icewind1991 is this 23 only or also needs 22 backport ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a user can have access to a file trough different paths, with differing permissions combine all permissions to determine if the user can share this file.
To test:
/aand/a/b/awithuser1without reshare permissions/a/bwithuser1with full permissionsuser1now has access tobfrom either/bor/a/buser1try to reshare/a/bCurrently, the ui shows the option to reshare
a/b, but errors when you try to reshareSharing
/balready works currently.