Skip to content

Replace deprecated String.prototype.substr() #31699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
CommanderRoot wants to merge 5 commits into from
Closed

Replace deprecated String.prototype.substr() #31699

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
179b29f
Replace deprecated String.prototype.substr()
CommanderRoot Aug 31, 2022
2878ec6
Replace deprecated String.prototype.substr()
CommanderRoot May 9, 2023
a611b2f
Replace deprecated String.prototype.substr()
CommanderRoot Nov 7, 2023
a477899
Add eslint rule to warn about deprecated substr() usage
CommanderRoot Nov 7, 2023
5956636
chore(assets): Recompile assets
CommanderRoot Nov 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Replace deprecated String.prototype.substr() 
.substr() is deprecated so we replace it with .slice() which work similarily but isn't deprecated

Signed-off-by: Tobias Speicher <[email protected]>
  • Loading branch information
@CommanderRoot
CommanderRoot committed Nov 7, 2023
commit a611b2fd07b35f64522fa1e2c68ba8a162c60239
2 changes: 1 addition & 1 deletion apps/files/src/components/VirtualList.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ export default Vue.extend({
}

// Get and consume reusable key or generate a new one
const key = unusedKeys.pop() || Math.random().toString(36).substr(2)
const key = unusedKeys.pop() || Math.random().toString(36).slice(2)
this.$_recycledPool[key] = item[this.dataKey]
return { key, item }
})
Expand Down
2 changes: 1 addition & 1 deletion apps/files_sharing/src/components/SharingEntryQuickShareSelect.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ export default {
},
dropdownId() {
// Generate a unique ID for ARIA attributes
return `dropdown-${Math.random().toString(36).substr(2, 9)}`
return `dropdown-${Math.random().toString(36).slice(2, 11)}`
},
},
watch: {
Expand Down