Require a recent phpunit version in integration and acceptance #31761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
come-nc
requested review from
a team,
CarlSchwan,
juliusknorr,
nickvergessen and
skjnldsv
and removed request for
a team
Merged
danxuliu
requested changes
Mar 31, 2022
Member
danxuliu
left a comment
danxuliu
left a comment
There was a problem hiding this comment.
Changing Assert::assertContains to Assert::assertStringContainsString is also needed in some integration tests; there might be other changes needed too, but I have not checked.
nickvergessen
approved these changes
Apr 4, 2022
CarlSchwan
reviewed
May 24, 2022
danxuliu
force-pushed
the
fix/upgarde-phpunit-in-ci-to-recent-version
branch
from
ea5770d to
40da863
Compare
Otherwise build with PHP>8 will fail as PHPUnit 6 does not support it Signed-off-by: Côme Chilliet <[email protected]>
danxuliu
force-pushed
the
fix/upgarde-phpunit-in-ci-to-recent-version
branch
from
40da863 to
8951f06
Compare
CarlSchwan
approved these changes
May 24, 2022
danxuliu
approved these changes
May 24, 2022
Member
danxuliu
left a comment
danxuliu
left a comment
There was a problem hiding this comment.
I fixed the remaining failures, rebased on latest master and squashed the fixups; CI is happy, so 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise build with PHP>8 will fail as PHPUnit 6 does not support it
Signed-off-by: Côme Chilliet [email protected]