Log why the login token can't be used for credentials #31826
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And always pass the exception object to the logger. Signed-off-by: Christoph Wurst <[email protected]>
ChristophWurst
added
bug
3. to review
ChristophWurst
requested review from
ArtificialOwl,
nickvergessen and
skjnldsv
and removed request for
a team
Member
Author
|
/backport to stable23 |
Member
Author
|
/backport to stable21 |
Member
Author
|
/backport to stable22 |
nickvergessen
approved these changes
Apr 4, 2022
Merged
ChristophWurst
requested review from
a team and
PVince81
and removed request for
a team
Merged
This was referenced Apr 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And always pass the exception object to the logger.
\OC\Authentication\Exceptions\InvalidTokenExceptionis thrown for different reasons. This makes debugging very hard if you don't see the actual exception's message or trace.