Skip to content

[stable22] Ignore errors when searching for bundled preview #31830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blizzz merged 1 commit into from
Apr 14, 2022
Merged

[stable22] Ignore errors when searching for bundled preview #31830

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Ignore errors when searching for bundled preview 
When an odt file is xml and not zip, it would throw a ValueError.
It will now just ignore this file and return null for the preview.

Signed-off-by: Côme Chilliet <[email protected]>
  • Loading branch information
@come-nc @backportbot
come-nc authored and backportbot[bot] committed Apr 4, 2022
commit eaff81c831ca82cca63712f180d68a33196c3319
2 changes: 1 addition & 1 deletion lib/private/Preview/Bundled.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ protected function extractThumbnail(File $file, $path): ?IImage {
$image->fixOrientation();

return $image;
} catch (\Exception $e) {
} catch (\Throwable $e) {
return null;
}
}
Expand Down