-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Fix: Birthday calendar issue with shared calendars #31859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Seems a good idea but also seems to have a lot of side effects. 🤔 |
|
I don't get how
|
I cannot find |
|
I was referring to the failed tests, didn't get a chance to look at this yet. |
|
Ok, fixed the problem. Let's see what the tests say now. |
|
i tried to implement it.. get this error:
this is line 210 right now: |
|
Are you sure you checked out the latest commit? |
|
thx.. you are correct.. my fault |
come-nc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small comment about the code, but I do not understand what this does and the implications.
ab74be8 to
297467f
Compare
|
/rebase |
|
@max65482 please rebase :) |
Signed-off-by: Maximilian Martin <[email protected]>
297467f to
245351f
Compare
|
Done! |
|
Thanks for the work @max65482 🚀 |
Fixes #3914 in nextcloud/calendar.
My understanding is that
{http://owncloud.org/ns}group-shareis wrongly assigned. It isfalsealthough an address book is shared with a group.This leads the BirthdayService to not update birthday calendars of group members. See
server/apps/dav/lib/CalDAV/BirthdayService.php
Line 356 in d228951
I must admit that I don't really understand the rationale of
{http://owncloud.org/ns}group-share. So please review carefully :)