Skip to content

Conversation

@artonge
Copy link
Contributor

@artonge artonge commented Apr 11, 2022

Fix tests after #31857

@artonge artonge added the 2. developing Work in progress label Apr 11, 2022
@artonge artonge added this to the Nextcloud 24 milestone Apr 11, 2022
@artonge artonge self-assigned this Apr 11, 2022
@artonge artonge added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Apr 11, 2022
@artonge artonge requested review from a team, PVince81, blizzz and come-nc and removed request for a team April 11, 2022 12:51
@PVince81
Copy link
Member

can you also add a test to validate that this setting works when enabled/disabled ?

Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 let's merge as it fixes CI, please add the tests separately

@PVince81 PVince81 merged commit 4626bfb into master Apr 12, 2022
@PVince81 PVince81 deleted the feat/dont_match_userid_tests branch April 12, 2022 07:43
@blizzz blizzz mentioned this pull request Apr 13, 2022
@backportbot-nextcloud
Copy link

The backport to stable24 failed. Please do this backport manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants