Skip to content

Conversation

@artonge
Copy link
Contributor

@artonge artonge commented Apr 11, 2022

Supersede #31824
Fix #24807

Signed-off-by: Gnana Sekar <[email protected]>
Signed-off-by: Louis Chemineau <[email protected]>
@artonge artonge force-pushed the contact-popover-hyperlink-issue-2 branch from acef539 to 7696e3f Compare April 11, 2022 15:13
@artonge artonge added this to the Nextcloud 24 milestone Apr 11, 2022
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good but didn't test

@szaimen szaimen requested review from a team, PVince81, Pytal and skjnldsv and removed request for a team April 11, 2022 15:27
@artonge
Copy link
Contributor Author

artonge commented Apr 11, 2022

@devsekar-1992 can you check that the change is still good ?

@devsekar-1992
Copy link
Contributor

@devsekar-1992 can you check that the change is still good ?

Yes @artonge

@Pytal Pytal merged commit 49d302d into master Apr 11, 2022
@Pytal Pytal deleted the contact-popover-hyperlink-issue-2 branch April 11, 2022 17:43
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 11, 2022
@artonge
Copy link
Contributor Author

artonge commented Apr 12, 2022

Thank you @devsekar-1992 ! Sorry it was such a drag for you, hopefully it will be smoother next time! :)

@devsekar-1992
Copy link
Contributor

@artonge No problem. It's one of the learnings of my first open-source contribution.

Thank you @szaimen @artonge @Pytal for accepting my first open-source contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish enhancement feature: contacts menu

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Contacts menu, more intuitive link to contact details

5 participants