Add settings to ignore second display name in search #31932
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PVince81
reviewed
Apr 11, 2022
artonge
force-pushed
the
feat/ignore_second_dn
branch
from
2249bb6 to
4ef93bf
Compare
PVince81
reviewed
Apr 12, 2022
Member
PVince81
left a comment
PVince81
left a comment
There was a problem hiding this comment.
Looks nice. Can you also add a unit test ? I see we already have a Collaborators/UserPluginTest
artonge
force-pushed
the
feat/ignore_second_dn
branch
8 times, most recently
from
baa45ab to
e081732
Compare
Contributor
Author
Done, thanks for the pointer. |
artonge
force-pushed
the
feat/ignore_second_dn
branch
from
e081732 to
2e145a6
Compare
8 tasks
blizzz
requested changes
Apr 12, 2022
artonge
force-pushed
the
feat/ignore_second_dn
branch
2 times, most recently
from
03cbf4d to
3c818fe
Compare
Signed-off-by: Louis Chemineau <[email protected]>
artonge
force-pushed
the
feat/ignore_second_dn
branch
from
3c818fe to
37f1c86
Compare
blizzz
approved these changes
Apr 13, 2022
Merged
Contributor
Author
|
/backport to stable22 |
Contributor
Author
|
/backport to stable23 |
|
The backport to stable22 failed. Please do this backport manually. |
|
The backport to stable23 failed. Please do this backport manually. |
|
The backport to stable24 failed. Please do this backport manually. |
artonge
added a commit
to nextcloud/documentation
that referenced
this pull request
Feb 12, 2024
From the following PRs: - nextcloud/server#31932 - nextcloud/server#31857 - nextcloud/server#31857 Signed-off-by: Louis Chemineau <[email protected]>
acataluddi
pushed a commit
to acataluddi/nextcloud-documentation
that referenced
this pull request
Apr 28, 2024
From the following PRs: - nextcloud/server#31932 - nextcloud/server#31857 - nextcloud/server#31857 Signed-off-by: Louis Chemineau <[email protected]> Signed-off-by: Adriano Cataluddi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When LDAP backend is used and a second Display name property is set, the display name value will look like that: "First Display Name (Second Display Name)". This break user search when autocomplete is deactivated.
This PR adds a setting to match the first display name with a totally not bulletproof regexp.
Fix https://github.com/nextcloud-gmbh/customer-feature-requests/issues/6