[3rdparty] Static classmap for 3rdparty #320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Any Blackfire comparison for the autoloader itself? ;) |
Member
Author
I have to wait for my new laptop for that to redo them.... |
rullzer
added
2. developing
LukasReschke
force-pushed
the
faster_autoloader
branch
from
1fe558b to
585e00e
Compare
rullzer
force-pushed
the
faster_autoloader
branch
from
585e00e to
a9df8b2
Compare
Member
Author
|
Rebased to have 5.4, 5.5, 5.6 and 7.0 unit tests running... |
Member
Author
|
@LukasReschke see https://blackfire.io/profiles/compare/3a2a4c5a-25b1-4cd1-a2d0-10211cc0afb0/graph Take a look at the CPU time saved. That is more interesting than the I/O wait since that is just random noise. |
rullzer
added
3. to review
Member
|
LGTM 👍 |
Member
|
👍 |
This speedsup classmap loading significantly on php 5.6 and higher. Older php versions are not affected.
MorrisJobke
force-pushed
the
faster_autoloader
branch
from
a9df8b2 to
9a3e2f6
Compare
Member
|
Rebased to get latest 3rdparty submodule ;) |
R0Wi
pushed a commit
to R0Wi/server
that referenced
this pull request
Nov 22, 2025
For every incoming request to the cloud, we do an extra read from the database. For every outgoing request, we do the same. Anyway, we haven’t used this thing once in a year; it’s easier to remove it than to transfer this flag to the ex_app table to optimize speed. Signed-off-by: Alexander Piskun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This speedsup classmap loading significantly on php 5.6 and higher.
Older php versions are not affected.
Lets see how CI feels
Requires nextcloud/3rdparty#4