Use stored user for PasswordUpdatedEvent #32016
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artonge
requested review from
CarlSchwan,
icewind1991 and
vanpertsch
and removed request for
a team
artonge
force-pushed
the
fix/PasswordUpdatedEvent_handling
branch
2 times, most recently
from
3268622 to
ad22d14
Compare
artonge
changed the title
come-nc
approved these changes
Apr 28, 2022
come-nc
reviewed
Apr 28, 2022
artonge
force-pushed
the
fix/PasswordUpdatedEvent_handling
branch
3 times, most recently
from
627f950 to
8517bb2
Compare
Contributor
Author
|
/rebase |
artonge
force-pushed
the
fix/PasswordUpdatedEvent_handling
branch
from
8517bb2 to
290697b
Compare
artonge
force-pushed
the
fix/PasswordUpdatedEvent_handling
branch
3 times, most recently
from
2b9d29f to
498681c
Compare
When handling PasswordUpdatedEvent event, we are calling getLoginName which does not exists. This PR adds a condition to use the previously stored user when handling PasswordUpdatedEvent. Signed-off-by: Louis Chemineau <[email protected]>
artonge
force-pushed
the
fix/PasswordUpdatedEvent_handling
branch
from
498681c to
816e782
Compare
Contributor
Author
|
CI failure unrelated, samba is always failing https://github.com/nextcloud/server/actions/workflows/smb-kerberos.yml |
Contributor
Author
|
Review ping :) |
CarlSchwan
approved these changes
May 16, 2022
Member
|
/backport to stable24 |
Member
|
/backport to stable23 |
Member
|
/backport to stable22 |
This was referenced Jun 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When handling
PasswordUpdatedEventevent, we are callinggetLoginNamewhich does not exist.This PR adds a condition to use the previously stored user when handling
PasswordUpdatedEvent.