Port files trashbin events to IEventDispatcher/IEventListener #32018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarlSchwan
force-pushed
the
cleanup/event/trashbin
branch
3 times, most recently
from
9af5d5f to
7079039
Compare
artonge
reviewed
Apr 20, 2022
Contributor
artonge
left a comment
artonge
left a comment
There was a problem hiding this comment.
Still a bunch of lint errors/warnings :)
CarlSchwan
force-pushed
the
cleanup/event/trashbin
branch
3 times, most recently
from
cba371e to
ccad4d3
Compare
come-nc
reviewed
Apr 25, 2022
come-nc
reviewed
Apr 25, 2022
come-nc
reviewed
Apr 25, 2022
7 tasks
CarlSchwan
force-pushed
the
cleanup/event/trashbin
branch
from
ccad4d3 to
0766816
Compare
come-nc
approved these changes
May 5, 2022
Merged
Member
|
As there is no feedback since a while I will close this ticket. |
come-nc
force-pushed
the
cleanup/event/trashbin
branch
from
2ceeac1 to
fa2936c
Compare
come-nc
force-pushed
the
cleanup/event/trashbin
branch
from
ad3e703 to
8a6761a
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| public function handle(Event $event): void { | ||
| if ($event instanceof NodeWrittenEvent) { | ||
| // Resize trash | ||
| if (!empty($this->userId)) { |
Check notice
Code scanning / Psalm
RiskyTruthyFalsyComparison
| } | ||
|
|
||
| public function handle(Event $event): void { | ||
| if ($event instanceof BeforeNodeDeletedEvent) { |
Check notice
Code scanning / Psalm
RedundantConditionGivenDocblockType
…Listener oc_hooks is deprecated and will at some point be removed Signed-off-by: Carl Schwan <[email protected]> Signed-off-by: Thomas Citharel <[email protected]> Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
Hooks are cleared in test bootstrap so switching to events activates them in tests. Signed-off-by: Côme Chilliet <[email protected]>
come-nc
force-pushed
the
cleanup/event/trashbin
branch
from
98986b7 to
af0b8fb
Compare
come-nc
added
3. to review
… unlink Signed-off-by: Côme Chilliet <[email protected]>
Contributor
|
The 4 ViewTest failures came from the fact that the trashbin wrapper is now registered and intercepts the rmdir and unlink calls to applies trashbin logic instead of actually deleting stuff. |
susnux
approved these changes
Sep 24, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
oc_hooks is deprecated and will at some point be removed