use and cache root storage info if a share can't be resolved #32076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
/backport to stable24 |
blizzz
approved these changes
Apr 22, 2022
icewind1991
added
2. developing
Member
Author
|
This might need some more work |
as is a broken share will never be cached Signed-off-by: Robin Appelman <[email protected]>
Signed-off-by: Robin Appelman <[email protected]>
icewind1991
force-pushed
the
cache-storage-info-failed-share
branch
from
cd6ff04 to
54ac585
Compare
CarlSchwan
approved these changes
Apr 22, 2022
icewind1991
added
3. to review
Member
|
Ci failure is unrelated (also saw it on other recent PRs) |
icewind1991
added a commit
that referenced
this pull request
May 11, 2022
the original reason for adding it no longer exist. This was added with #30985 since then the share source storage was also used, however this was changed with #32076 Signed-off-by: Robin Appelman <[email protected]>
icewind1991
added a commit
that referenced
this pull request
May 11, 2022
the original reason for adding it no longer exist. This was added with #30985 since then the share source storage was also used, however this was changed with #32076 Signed-off-by: Robin Appelman <[email protected]>
backportbot-nextcloud bot
pushed a commit
that referenced
this pull request
May 12, 2022
the original reason for adding it no longer exist. This was added with #30985 since then the share source storage was also used, however this was changed with #32076 Signed-off-by: Robin Appelman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as is a broken share will never be cached
Follow up from #32048