Skip to content

[stable23] Do not update _lastChanged on auto-detected attributes #32120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pytal merged 2 commits into from
Apr 25, 2022
Merged

[stable23] Do not update _lastChanged on auto-detected attributes #32120

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e1ac0a
Do not update _lastChanged on auto-detected attributes
come-nc Mar 17, 2022
a8ebd99
Avoid updating _lastChange when nothing is changed in the configuration
come-nc Mar 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Do not update _lastChanged on auto-detected attributes 
Signed-off-by: Côme Chilliet <[email protected]>
  • Loading branch information
@come-nc @backportbot
come-nc authored and backportbot[bot] committed Apr 25, 2022
commit 6e1ac0a9bbf7aea359f9e338f507d7d006396107
6 changes: 5 additions & 1 deletion apps/user_ldap/lib/Configuration.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,6 +262,7 @@ public function readConfiguration() {
*/
public function saveConfiguration() {
$cta = array_flip($this->getConfigTranslationArray());
$changed = false;
foreach ($this->unsavedChanges as $key) {
$value = $this->config[$key];
switch ($key) {
Expand Down Expand Up @@ -291,9 +292,12 @@ public function saveConfiguration() {
if (is_null($value)) {
$value = '';
}
$changed = true;
$this->saveValue($cta[$key], $value);
}
$this->saveValue('_lastChange', time());
if ($changed) {
$this->saveValue('_lastChange', (string)time());
}
$this->unsavedChanges = [];
}

Expand Down