Skip to content

Conversation

@vitormattos
Copy link

@vitormattos vitormattos commented Apr 27, 2022

I think that this approach of EmojiHelper is very simple but don't work fine to validate allowed emojis to use.

I needed put more options in condition to pass with all emojis but when I tried to test with non emoji chars, I don't got success and a simple 'a' passed as a emoji, because this I don't implemented the testInvalidEmoji.

Signed-off-by: Vitor Mattos <[email protected]>
@vitormattos vitormattos added the 3. to review Waiting for reviews label Apr 27, 2022
@vitormattos vitormattos added this to the Nextcloud 25 milestone Apr 27, 2022
@vitormattos vitormattos self-assigned this Apr 27, 2022
@vitormattos
Copy link
Author

Duplicated of #31703

@vitormattos vitormattos deleted the feature/add-tests-to-validate-emojis branch April 28, 2022 11:03
@vitormattos vitormattos restored the feature/add-tests-to-validate-emojis branch April 28, 2022 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants