Skip to content

Respect user settings in php.ini if they are big enough #32216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
artonge merged 3 commits into from
May 17, 2022
Merged

Respect user settings in php.ini if they are big enough #32216

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2596644
Respect user settings in php.ini if they are big enough
mickenordin Apr 29, 2022
30fe91a
Simpler version as proposed by @artonage
mickenordin Apr 30, 2022
0ace183
Fix suggestions by @artonage
mickenordin May 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Respect user settings in php.ini if they are big enough 
In the admin guide:
* https://docs.nextcloud.com/server/latest/admin_manual/configuration_files/big_file_upload_configuration.html

it is mentioned that you can tweek:
* max_input_time
* max_execution_time

in order to enable larger file uploads. However, the current codebase
will hard code these values to one hour, no matter what the user sets in
php.ini.

This patch will allow the user to set these settings in php.ini and they
will be respected, if and only if, they are set to something bigger than
3600 seconds.

Signed-off-by: Micke Nordin <[email protected]>
  • Loading branch information
@mickenordin
mickenordin committed Apr 29, 2022
commit 259664468a009b03d6d974613e47f0e140f7332b
28 changes: 22 additions & 6 deletions lib/base.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -623,16 +623,32 @@ public static function init() {
throw new \RuntimeException('Could not set timezone to UTC');
}


//try to configure php to enable big file uploads.
//this doesn´t work always depending on the web server and php configuration.
//Let´s try to overwrite some defaults anyway
//this doesn´t work always depending on the webserver and php configuration.
//Let´s try to overwrite some defaults if they are smaller than 1 hour
// One hour is 3600 seconds
$time_limit = 3600;

$max_execution_time_from_ini = @ini_get('max_execution_time');
$biggest_max_execution_time = $time_limit;
if (isset($max_execution_time_from_ini)) {
$biggest_max_execution_time = max($time_limit, intval($max_execution_time_from_ini));
}
@ini_set('max_execution_time', strval($biggest_max_execution_time));

$max_input_time_from_ini = @ini_get('max_input_time');
$biggest_max_input_time = $time_limit;
if (isset($max_input_time_from_ini)) {
$biggest_max_input_time = max($time_limit, intval($max_input_time_from_ini));
}
@ini_set('max_input_time', strval($biggest_max_input_time));

//try to set the maximum execution time to 60min
//try to set the maximum execution time to the largest time limit we have
if (strpos(@ini_get('disable_functions'), 'set_time_limit') === false) {
@set_time_limit(3600);
$biggest_time_limit = max($time_limit, $biggest_max_execution_time, $biggest_max_input_time);
@set_time_limit($biggest_time_limit);
}
@ini_set('max_execution_time', '3600');
@ini_set('max_input_time', '3600');

self::setRequiredIniValues();
self::handleAuthHeaders();
Expand Down