Skip to content

Revert "Revert "[stable24] Make the order of reactions reliable"" #32241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickvergessen merged 1 commit into from
May 5, 2022
Merged

Revert "Revert "[stable24] Make the order of reactions reliable"" #32241

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Revert "Revert "[stable24] Make the order of reactions reliable""
  • Loading branch information
@blizzz
blizzz authored May 2, 2022
commit f44f022483a5fd60550f555e1eeeab7a0a086d15
1 change: 1 addition & 0 deletions lib/private/Comments/Manager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1269,6 +1269,7 @@ private function sumReactions(string $parentId): void {
->where($totalQuery->expr()->eq('r.parent_id', $qb->createNamedParameter($parentId)))
->groupBy('r.reaction')
->orderBy('total', 'DESC')
->addOrderBy('r.reaction', 'ASC')
->setMaxResults(20);

$jsonQuery = $this->dbConn->getQueryBuilder();
Expand Down