Fix JSON error when comment has no reactions #32288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/backport to stable24 |
nickvergessen
requested review from
a team,
CarlSchwan and
come-nc
and removed request for
a team
blizzz
approved these changes
May 6, 2022
come-nc
reviewed
May 9, 2022
Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
force-pushed
the
techdebt/noid/fix-json-error
branch
from
9104f8e to
4e0595f
Compare
come-nc
approved these changes
May 9, 2022
vitormattos
approved these changes
May 9, 2022
|
The backport to stable24 failed. Please do this backport manually. |
This was referenced Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise talk integration tests spam this error:
{ "Exception": "Error", "Message": "json_decode(): Passing null to parameter #1 ($json) of type string is deprecated at /home/nickv/Nextcloud/25/server/lib/private/Comments/Manager.php#113", "Code": 0, "Trace": [ { "function": "onAll", "class": "OC\\Log\\ErrorHandler", "type": "::" }, { "file": "/home/nickv/Nextcloud/25/server/lib/private/Comments/Manager.php", "line": 113, "function": "json_decode" }, { "file": "/home/nickv/Nextcloud/25/server/appsbabies/spreed/lib/Chat/CommentsManager.php", "line": 40, "function": "normalizeDatabaseData", "class": "OC\\Comments\\Manager", "type": "->" }, { "file": "/home/nickv/Nextcloud/25/server/lib/private/Comments/Manager.php", "line": 299, "function": "getCommentFromData", "class": "OCA\\Talk\\Chat\\CommentsManager", "type": "->" }, { "file": "/home/nickv/Nextcloud/25/server/appsbabies/spreed/lib/Manager.php", "line": 227, "function": "get", "class": "OC\\Comments\\Manager", "type": "->" }, { "file": "/home/nickv/Nextcloud/25/server/appsbabies/spreed/lib/Room.php", "line": 351, "function": "loadLastCommentInfo", "class": "OCA\\Talk\\Manager", "type": "->" }, { "file": "/home/nickv/Nextcloud/25/server/appsbabies/spreed/lib/Controller/RoomController.php", "line": 534, "function": "getLastMessage", "class": "OCA\\Talk\\Room", "type": "->" }, { "file": "/home/nickv/Nextcloud/25/server/appsbabies/spreed/lib/Controller/RoomController.php", "line": 346, "function": "formatRoomV4", "class": "OCA\\Talk\\Controller\\RoomController", "type": "->" }, { "file": "/home/nickv/Nextcloud/25/server/appsbabies/spreed/lib/Controller/RoomController.php", "line": 1395, "function": "formatRoom", "class": "OCA\\Talk\\Controller\\RoomController", "type": "->" }, { "file": "/home/nickv/Nextcloud/25/server/lib/private/AppFramework/Http/Dispatcher.php", "line": 225, "function": "joinRoom", "class": "OCA\\Talk\\Controller\\RoomController", "type": "->" }, { "file": "/home/nickv/Nextcloud/25/server/lib/private/AppFramework/Http/Dispatcher.php", "line": 133, "function": "executeController", "class": "OC\\AppFramework\\Http\\Dispatcher", "type": "->" }, { "file": "/home/nickv/Nextcloud/25/server/lib/private/AppFramework/App.php", "line": 172, "function": "dispatch", "class": "OC\\AppFramework\\Http\\Dispatcher", "type": "->" }, { "file": "/home/nickv/Nextcloud/25/server/lib/private/Route/Router.php", "line": 298, "function": "main", "class": "OC\\AppFramework\\App", "type": "::" }, { "file": "/home/nickv/Nextcloud/25/server/ocs/v1.php", "line": 62, "function": "match", "class": "OC\\Route\\Router", "type": "->" }, { "file": "/home/nickv/Nextcloud/25/server/ocs/v2.php", "line": 23, "args": [ "/home/nickv/Nextcloud/25/server/ocs/v1.php" ], "function": "require_once" } ], "File": "/home/nickv/Nextcloud/25/server/lib/private/Log/ErrorHandler.php", "Line": 99, "CustomMessage": "--" }