Add a public abstract class for the command base #32332
Conversation
The OC\Core\Command\Base is used in quite many apps as it brings the base for different output methods and allows autocomplete. Therefor this should be exposed as OCP so apps are actually allowed to benefit from it. Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
added
3. to review
nickvergessen
requested review from
a team,
CarlSchwan,
ChristophWurst,
skjnldsv and
vanpertsch
and removed request for
a team
| /** | ||
| * @since 25.0.0 | ||
| */ | ||
| abstract class ACommand extends Command implements CompletionAwareInterface { |
There was a problem hiding this comment.
I don't think we can expose Symphony/Comman in the public interface 😞
There was a problem hiding this comment.
Well every app that providers an OCC command already uses it, either directly or by inheriting OC\Core\Command\Base, because only those can be registered:
https://github.com/nextcloud/3rdparty/blob/e0b9473487114accdba2e5a829ba763589ce5860/symfony/console/Application.php#L473
So I guess we just do it under that accepted risk
There was a problem hiding this comment.
I would not because we don't get any independence from this.
There was a problem hiding this comment.
Well we would get a bit more exposure and I don't feel like starting to document private API or Symfony directly.
But I guess we then just don't have it nicely
nickvergessen
deleted the
techdebt/noid/add-public-abstract-class-for-base-command
branch
The OC\Core\Command\Base is used in quite many apps
as it brings the base for different output methods
and allows autocomplete. Therefor this should be
exposed as OCP so apps are actually allowed to
benefit from it.
Signed-off-by: Joas Schilling [email protected]