remove storage wrappers when deleting the user storage #32357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robin Appelman <[email protected]>
icewind1991
requested review from
a team,
blizzz,
come-nc and
juliusknorr
and removed request for
a team
8 tasks
CarlSchwan
approved these changes
May 13, 2022
juliusknorr
approved these changes
May 16, 2022
Member
|
@icewind1991 Shall we backport to all stable branches or just 23? |
Member
|
@juliushaertl this fixes #29582 as well back to stable22, so this should be backported to all non-EOL stable branches |
Member
|
/backport to stable24 |
Member
|
/backport to stable23 |
Member
|
/backport to stable22 |
This was referenced May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mostly matters for stable23 and lower since with 24 the filesystem setup doesn't get triggered by most(?) code paths that trigger the user delete so no wrappers are there in the first place.
To test:
occ user:deletethe userShould fix #32251