Fix psalm issues related to the user backend #32378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarlSchwan
force-pushed
the
fix/psalm-userbackend
branch
from
8aba719 to
6320f62
Compare
come-nc
approved these changes
May 16, 2022
- Reflect the actual return value returned by the implementation in the the interface. E.g. IUser|bool -> IUser|false - Remove $hasLoggedIn parameter from private countUser implementation. Replace the two call with the equivalent countSeenUser - getBackend is nuallable, add this to the interface - Use backend interface to make psalm happy about call to undefined methods. Also helps with getting rid at some point of the old implementActions Signed-off-by: Carl Schwan <[email protected]>
CarlSchwan
force-pushed
the
fix/psalm-userbackend
branch
from
6320f62 to
9ec0cb0
Compare
kesselb
approved these changes
May 20, 2022
Member
Author
|
ci failure unrelated |
| * @since 15.0.0 | ||
| */ | ||
| public function getBackend(); | ||
| public function getBackend(): ?UserInterface; |
Member
There was a problem hiding this comment.
This is a breaking change. Any implementation of IUser needs to adjust their signature line to include this.
Can we avoid it and just go with @return UserInterface|null instead?
This was referenced May 23, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the interface. E.g. IUser|bool -> IUser|false
Replace the two call with the equivalent countSeenUser
methods. Also helps with getting rid at some point of the old
implementActions
Test plan