Use background color for mix of --color-primary-light-hover #32381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julius Härtl <[email protected]>
juliusknorr
requested review from
a team,
Pytal,
artonge,
marcoambrosini and
skjnldsv
and removed request for
a team
CarlSchwan
approved these changes
May 13, 2022
Member
CarlSchwan
left a comment
CarlSchwan
left a comment
There was a problem hiding this comment.
I did the same change in #31584
This kinda means that --color-primary-light and --color-primary-light-hover are equal, this might not be ideal. Maybe change the mix value for hover to be a bit darker or lighter?
Member
|
Already part of #32261 |
skjnldsv
requested changes
May 13, 2022
Member
skjnldsv
left a comment
skjnldsv
left a comment
There was a problem hiding this comment.
This is also not how the initial implementation is defined :)
This should be
'--color-primary-light-hover' => $this->util->mix($colorPrimaryLight, $colorMainText, 90),
Member
Author
|
All right, then lets close this in favour of #32261 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix how the --color-primary-light-hover variable is calculated to give it a proper light tint based on the background rather than the foreground color.