Stop BackgroundCleanupJob when previews are disabled #32440
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carl Csaposs <[email protected]>
ghost
commented
May 16, 2022
Author
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
This is my first PR so please look at the diff carefully and let me know if there's anything I could improve.
Signed-off-by: Carl Csaposs <[email protected]>
Author
|
I noticed there's a CI to block fixup and squash commits--should I rebase (i.e. squash efc6412 into the first commit) and force push? |
szaimen
requested review from
a team,
come-nc,
icewind1991 and
skjnldsv
and removed request for
a team
Signed-off-by: Carl Csaposs <[email protected]>
ghost
closed this by deleting the head repository
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30793