Fix backgroundjobs mode radio #32465
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kesselb
requested review from
a team,
CarlSchwan,
PVince81,
Pytal and
vanpertsch
and removed request for
a team
Signed-off-by: Daniel Kesselberg <[email protected]>
kesselb
force-pushed
the
bug/noid/fix-backgroundjobs-mode
branch
from
e448966 to
4e71ff7
Compare
Member
|
It seems that #32443 supersedes this one @CarlSchwan? |
Member
We still need a fix for stable24 |
CarlSchwan
approved these changes
May 18, 2022
Contributor
Author
Nice 🎉
OK! I will rebase the branch to stable24, recompile and delete the backport request. |
kesselb
changed the title
kesselb
changed the title
Contributor
Author
|
PR for stable24: #32470 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Radio input's for background jobs mode (ajax, webcron, cron) do not work anymore for main and stable24.
Change event works but
$(_this).is(':checked')is always false. It's related to the arrow syntax and lexical this binding.Helpful reading: https://stackoverflow.com/questions/27670401/using-jquery-this-with-es6-arrow-functions-lexical-this-binding