Make sure activities are not created when a deleted calendar object expires #32471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xpires Closes nextcloud/activity#784 Signed-off-by: Thomas Citharel <[email protected]>
tcitworld
added
bug
3. to review
ChristophWurst
approved these changes
Jun 1, 2022
Member
|
S3 failure is most definitely unrelated. |
Member
|
/backport to stable24 |
Member
|
/backport to stable23 |
Member
|
/backport to stable22 |
Contributor
😎 |
kesselb
approved these changes
Jun 1, 2022
This was referenced Jun 1, 2022
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
deleted_atproperty was not being fetched ingetCalendarObjectand then passed into theCalendarObjectDeletedEvent, so the handling inActivityUpdaterListenerdidn't work properly.Added a small assertion in
CalDavBackendTestto make sure the key is present. And you get a test for free inActivityUpdaterListener.Closes nextcloud/activity#784