Skip to content

[stable24] Fix cropped image generated when not asked #32483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
CarlSchwan merged 1 commit into from
Jul 6, 2022
Merged

[stable24] Fix cropped image generated when not asked #32483

CarlSchwan merged 1 commit into from
Jul 6, 2022

Conversation

@backportbot-nextcloud
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented May 18, 2022

backport of #32451

@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 24.0.1 milestone May 18, 2022
@blizzz blizzz added the 3. to review Waiting for reviews label May 19, 2022
@blizzz blizzz mentioned this pull request Jun 9, 2022
Merged
2 tasks
@PVince81
Copy link
Member

PVince81 commented Jun 10, 2022

/rebase

@nextcloud-command nextcloud-command force-pushed the backport/32451/stable24 branch from b02f2b5 to 62aec22 Compare June 10, 2022 15:25
@PVince81 PVince81 added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 10, 2022
blizzz
blizzz requested changes Jun 10, 2022
View reviewed changes
Copy link
Member

@blizzz blizzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI unhappy

@blizzz
Copy link
Member

blizzz commented Jun 13, 2022

moving to 24.0.3

@blizzz blizzz mentioned this pull request Jun 17, 2022
Merged
@blizzz blizzz added 2. developing Work in progress and removed 4. to release Ready to be released and/or waiting for tests to finish labels Jun 21, 2022
@skjnldsv skjnldsv mentioned this pull request Jul 5, 2022
Merged
18 tasks
@blizzz
Copy link
Member

blizzz commented Jul 6, 2022

@CarlSchwan PHP CS is unhappy, can you have a look?

@CarlSchwan
Fix cropped image generated when not asked
c3621f2 
The $crop parameter was not propagated to the imaginary pipeline and
instead it used the smartcrop algorithm always

Signed-off-by: Carl Schwan <[email protected]>
@CarlSchwan CarlSchwan force-pushed the backport/32451/stable24 branch from 62aec22 to c3621f2 Compare July 6, 2022 12:33
miaulalala
miaulalala approved these changes Jul 6, 2022
View reviewed changes
Copy link
Contributor

@miaulalala miaulalala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skjnldsv skjnldsv requested a review from blizzz July 6, 2022 13:49
@CarlSchwan CarlSchwan merged commit 7c1c7ba into stable24 Jul 6, 2022
@CarlSchwan CarlSchwan deleted the backport/32451/stable24 branch July 6, 2022 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@miaulalala miaulalala miaulalala approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl

@PVince81 PVince81 Awaiting requested review from PVince81

@blizzz blizzz Awaiting requested review from blizzz

Assignees

No one assigned

Labels

2. developing Work in progress bug regression

Projects

None yet

Milestone

Nextcloud 24.0.3

Development

Successfully merging this pull request may close these issues.

6 participants

@PVince81 @blizzz @miaulalala @skjnldsv @CarlSchwan