Skip to content

Fix default value not consistent with interface #32597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
CarlSchwan wants to merge 1 commit into from
Closed

Fix default value not consistent with interface #32597

CarlSchwan wants to merge 1 commit into from

Conversation

@CarlSchwan
Copy link
Member

@CarlSchwan CarlSchwan commented May 25, 2022 

<?php
// lib/public/GroupInterface.php:99
public function getGroups($search = '', $limit = -1, $offset = 0);

@CarlSchwan CarlSchwan added the bug label May 25, 2022
@CarlSchwan CarlSchwan requested review from a team and blizzz May 25, 2022 14:35
@CarlSchwan CarlSchwan self-assigned this May 25, 2022
@CarlSchwan CarlSchwan requested review from PVince81 and skjnldsv and removed request for a team May 25, 2022 14:35
PVince81
PVince81 approved these changes Jun 2, 2022
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 assuming you tested it

ArtificialOwl
ArtificialOwl reviewed Jun 2, 2022
View reviewed changes
@skjnldsv skjnldsv removed their request for review June 2, 2022 15:26
@CarlSchwan CarlSchwan force-pushed the fix/unified-group-retrival branch from 734f803 to f541174 Compare October 16, 2022 18:01
@skjnldsv
Copy link
Member

skjnldsv commented Oct 17, 2023

#36592

@skjnldsv skjnldsv closed this Oct 17, 2023
@skjnldsv skjnldsv deleted the fix/unified-group-retrival branch October 17, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ArtificialOwl ArtificialOwl ArtificialOwl left review comments

@PVince81 PVince81 PVince81 approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@blizzz blizzz Awaiting requested review from blizzz

Assignees

@CarlSchwan CarlSchwan

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@CarlSchwan @skjnldsv @PVince81 @ArtificialOwl