[stable22] Improve warning about missing pnctl #32605
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backportbot-nextcloud
bot
requested review from
CarlSchwan,
GretaD,
come-nc,
icewind1991,
juliusknorr and
kesselb
szaimen
reviewed
May 26, 2022
console.php
Outdated
| if (!function_exists('pcntl_signal') && !in_array('--no-warnings', $argv)) { | ||
| if (!(function_exists('pcntl_signal') && function_exists('pcntl_signal_dispatch')) && !in_array('--no-warnings', $argv)) { | ||
| echo "The process control (PCNTL) extensions are required in case you want to interrupt long running commands - see https://www.php.net/manual/en/book.pcntl.php" . PHP_EOL; | ||
| echo "Additionally the function 'pcntl_signal' and 'pcntl_signal_dispatch' need to be enabeld in your php.ini." . PHP_EOL; |
Contributor
There was a problem hiding this comment.
Suggested change
| echo "Additionally the function 'pcntl_signal' and 'pcntl_signal_dispatch' need to be enabeld in your php.ini." . PHP_EOL; | |
| echo "Additionally the function 'pcntl_signal' and 'pcntl_signal_dispatch' need to be enabled in your php.ini." . PHP_EOL; |
Signed-off-by: Carl Schwan <[email protected]>t
CarlSchwan
force-pushed
the
backport/32575/stable22
branch
from
7243177 to
cf8835b
Compare
szaimen
approved these changes
Jun 1, 2022
Merged
solracsf
approved these changes
Jul 1, 2022
Contributor
|
CI failure unrelated and the sign-off is there but not in the required form ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #32575