Use JSON_THROW_ON_ERROR instead of custom error handling #32628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarlSchwan
approved these changes
May 27, 2022
nickvergessen
approved these changes
May 27, 2022
Signed-off-by: Julius Härtl <[email protected]>
juliusknorr
force-pushed
the
bugfix/noid/json-throw
branch
from
b9bcdce to
3901a93
Compare
juliusknorr
added
4. to release
ChristophWurst
approved these changes
May 30, 2022
Member
|
Failure is also on master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way we can rely on json_encode for the actual error message, as there might be more than just malformed UTF8 characters and avoid to always dump the full response data into the logs.
Source of the recent report that this happened with text are addressed separately in nextcloud/text#2385