Skip to content

Make user status heartbeat API publicly accessible #32646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
CarlSchwan merged 1 commit into from
Jul 21, 2022
Merged

Make user status heartbeat API publicly accessible #32646

CarlSchwan merged 1 commit into from
Jul 21, 2022

Conversation

@provokateurin
Copy link
Member

@provokateurin provokateurin commented May 29, 2022

I want to use the heartbeat in my app, but the API currently can't be access without CSRF stuff.

CarlSchwan
CarlSchwan approved these changes May 30, 2022
View reviewed changes
Copy link
Member

@CarlSchwan CarlSchwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would be fine with this

@CarlSchwan
Copy link
Member

CarlSchwan commented May 30, 2022

Please fix the dco 😅

@provokateurin
Copy link
Member Author

provokateurin commented Jun 1, 2022

@CarlSchwan fixed it and rebased. Anything missing?

@provokateurin
Copy link
Member Author

provokateurin commented Jun 8, 2022

@CarlSchwan fixed the conflicts. Could you please look at this again?

@CarlSchwan CarlSchwan requested review from a team, ArtificialOwl, icewind1991 and skjnldsv and removed request for a team June 8, 2022 14:19
@szaimen szaimen added this to the Nextcloud 25 milestone Jun 9, 2022
@szaimen szaimen added enhancement 3. to review Waiting for reviews labels Jun 9, 2022
@provokateurin
Copy link
Member Author

provokateurin commented Jun 23, 2022

Fixed the DCO and the broken JS

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 24, 2022
@provokateurin
Copy link
Member Author

provokateurin commented Jun 24, 2022

Fixed the lint once again 🙈

@provokateurin provokateurin mentioned this pull request Jul 6, 2022
Closed
@provokateurin
Copy link
Member Author

provokateurin commented Jul 21, 2022

Will this just get merged right before the 25.0.0 release? Sorry I'm unsure what the status here is.

@CarlSchwan
Copy link
Member

CarlSchwan commented Jul 21, 2022

Will this just get merged right before the 25.0.0 release? Sorry I'm unsure what the status here is.

sorry this was forgotten but is ready to go, can you fix the conflict?

git rebase master
npm ci && npm run build && npm run sass && npm run sass:icons
git push -f

@provokateurin
Copy link
Member Author

provokateurin commented Jul 21, 2022

Will do!

@provokateurin
Copy link
Member Author

provokateurin commented Jul 21, 2022

Done

@CarlSchwan
Copy link
Member

CarlSchwan commented Jul 21, 2022

cool thanks now let see if the ci is still happy :)

@provokateurin
Copy link
Member Author

provokateurin commented Jul 21, 2022

Hm errors don't look related.

@CarlSchwan CarlSchwan merged commit bff1e9a into nextcloud:master Jul 21, 2022
@CarlSchwan
Copy link
Member

CarlSchwan commented Jul 21, 2022

It wasn't related

@provokateurin
Copy link
Member Author

provokateurin commented Jul 21, 2022

Thanks!

@skjnldsv skjnldsv mentioned this pull request Aug 11, 2022
Merged
@provokateurin provokateurin mentioned this pull request Jan 18, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl

@icewind1991 icewind1991 Awaiting requested review from icewind1991

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish enhancement

Projects

None yet

Milestone

Nextcloud 25

Development

Successfully merging this pull request may close these issues.

4 participants

@provokateurin @CarlSchwan @skjnldsv @szaimen