Skip to content

[stable24] Fix share permissions rendering #32674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PVince81 merged 1 commit into from
Jun 10, 2022
Merged

[stable24] Fix share permissions rendering #32674

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix share permissions rendering 
The `SHARE` permissions falls into the `default` case in the switch case, causing the rendering to look like ` , Upload, Read`.

This PR changes the return value of the `default` case and adds a `filter` to remove those values.

Signed-off-by: Louis Chemineau <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
  • Loading branch information
@artonge
artonge committed Jun 9, 2022
commit 8a2b70fe67c8720ab4d6e0e91517fac09a59ceaa
3 changes: 2 additions & 1 deletion apps/files_sharing/src/components/SharePermissionsEditor.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,9 +163,10 @@ export default {
case this.atomicPermissions.DELETE:
return this.t('files_sharing', 'Delete')
default:
return ''
return null
}
})
.filter(permissionLabel => permissionLabel !== null)
.join(', ')
},

Expand Down
4 changes: 2 additions & 2 deletions dist/files_sharing-files_sharing_tab.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/files_sharing-files_sharing_tab.js.map
View file
Open in desktop

Large diffs are not rendered by default.