Skip to content

Conversation

@Pytal
Copy link
Member

@Pytal Pytal commented Jun 2, 2022

This is functionally equivalent but explicitly handles all scopes and is slightly more restrictive by returning a placeholder in the single case where a PropertyDoesNotExistException is thrown when querying for the avatar account property

To Do

  • Add new test cases
  • Fix tests

@Pytal Pytal added bug 3. to review Waiting for reviews labels Jun 2, 2022
@Pytal Pytal added this to the Nextcloud 25 milestone Jun 2, 2022
@Pytal Pytal requested review from a team and blizzz June 2, 2022 01:44
@Pytal Pytal self-assigned this Jun 2, 2022
@Pytal Pytal requested review from ArtificialOwl and juliusknorr and removed request for a team June 2, 2022 01:44
@Pytal
Copy link
Member Author

Pytal commented Jun 2, 2022

/backport to stable24

@Pytal
Copy link
Member Author

Pytal commented Jun 2, 2022

/backport to stable23

@Pytal
Copy link
Member Author

Pytal commented Jun 2, 2022

/backport to stable22

Copy link
Member

@blizzz blizzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps some tests though?

@Pytal Pytal added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Jun 2, 2022
@Pytal Pytal force-pushed the fix/get-avatar-authz branch from 00e17c9 to e148c64 Compare June 3, 2022 00:06
@Pytal Pytal added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jun 3, 2022
@Pytal Pytal requested a review from artonge June 3, 2022 01:07
@Pytal Pytal force-pushed the fix/get-avatar-authz branch from e148c64 to 14e9b64 Compare June 3, 2022 18:35
@Pytal Pytal requested a review from juliusknorr June 3, 2022 18:59
Pytal added 2 commits June 7, 2022 23:57
Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
@Pytal Pytal force-pushed the fix/get-avatar-authz branch from 14e9b64 to 7c50dd8 Compare June 7, 2022 23:57
@Pytal Pytal requested a review from artonge June 8, 2022 00:00
@Pytal Pytal removed the 3. to review Waiting for reviews label Jun 8, 2022
@Pytal Pytal added the 4. to release Ready to be released and/or waiting for tests to finish label Jun 8, 2022
@Pytal
Copy link
Member Author

Pytal commented Jun 8, 2022

CI failure unrelated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants