Properly calculate carret position #32703
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artonge
force-pushed
the
fix/carret_position
branch
2 times, most recently
from
66dd45d to
158ef5c
Compare
artonge
requested review from
CarlSchwan and
skjnldsv
and removed request for
skjnldsv
artonge
added
3. to review
artonge
requested review from
a team,
PVince81 and
szaimen
and removed request for
a team
Member
|
test with disabled notifications app |
Contributor
Author
Checked, it works |
Contributor
Author
|
Ci failure unrelated |
artonge
force-pushed
the
fix/carret_position
branch
from
158ef5c to
744466b
Compare
The carret position is currently hard coded based on the position of the icon in the header. This PR calculate its position relatively to the header icon. Signed-off-by: Louis Chemineau <[email protected]>
artonge
force-pushed
the
fix/carret_position
branch
from
744466b to
719515a
Compare
CarlSchwan
approved these changes
Jun 7, 2022
Contributor
Author
|
CI failure unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The carret position is currently hard coded based on the position of the icon in the header.
This PR calculates its position relatively.