-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Fix email shares not being shown to other users #32719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6d1f36f to
46f8090
Compare
Member
Author
|
/backport to stable24 |
Member
Author
|
/backport to stable23 |
Member
Author
|
/backport to stable22 |
This comment was marked as resolved.
This comment was marked as resolved.
come-nc
reviewed
Jun 7, 2022
icewind1991
approved these changes
Jun 7, 2022
Member
|
@st3iny please squash |
49c380e to
2d8319d
Compare
CarlSchwan
approved these changes
Jun 10, 2022
Member
|
suspicious failure: |
Signed-off-by: Richard Steinmetz <[email protected]>
2d8319d to
c1f054a
Compare
Member
Author
That seems like a false alarm. This error also exists in other drone runs. I rebased to latest master to fix the failing scenario. I ran the integration test locally and it did not fail after rebasing. |
Member
Author
|
/backport to stable23 |
Member
Author
|
/backport to stable22 |
This was referenced Jun 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I adapted the logic from
server/lib/private/Share20/DefaultShareProvider.php
Lines 729 to 740 in 6d5d91f
How to reproduce?
Expected behaviour:
Share by mail is shown to other users in the same group. Sharing sub folders of groupfolders with users works like this too.
Current behaviour
Share is only shown to the admin who created the share.
Screenshots