Skip to content

Augment keyboard accessibility of the contacts menu #32736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pytal merged 1 commit into from
Jun 8, 2022
Merged

Augment keyboard accessibility of the contacts menu #32736

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Augment keyboard accessibility of contacts menu 
Signed-off-by: Christopher Ng <[email protected]>
  • Loading branch information
@Pytal
Pytal committed Jun 7, 2022
commit c1054ea5eba131e82b3e3e352d9838f29596111f
25 changes: 20 additions & 5 deletions core/css/server.css
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion core/css/server.css.map
View file
Open in desktop

Large diffs are not rendered by default.

25 changes: 20 additions & 5 deletions core/css/styles.css
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion core/css/styles.css.map
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

36 changes: 30 additions & 6 deletions core/css/styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1015,6 +1015,16 @@ span.ui-icon {
opacity: 1 !important;
}
}

#contactsmenu-menu {
a {
padding: 2px;

&:focus-visible {
box-shadow: inset 0 0 0 2px var(--color-main-text) !important; // override rule in core/css/headers.scss #header a:focus-visible
}
}
}
}

#header .header-right > div#contactsmenu > .menu {
Expand Down Expand Up @@ -1059,10 +1069,6 @@ span.ui-icon {
padding: 3px 3px 3px 10px;
border-bottom: 1px solid var(--color-border);

:last-of-type {
border-bottom: none;
}

.avatar {
height: 32px;
width: 32px;
Expand Down Expand Up @@ -1093,15 +1099,33 @@ span.ui-icon {
.top-action, .second-action, .other-actions {
width: 16px;
height: 16px;
padding: 14px;
opacity: .5;
cursor: pointer;

:hover {
&:not(button) {
padding: 14px;
}

&:hover,
&:active,
&:focus {
opacity: 1;
}
}

button.other-actions {
margin: 5px;

&:focus {
border-color: transparent;
box-shadow: 0 0 0 2px var(--color-main-text);
}

&:focus-visible {
border-radius: var(--border-radius-pill);
}
}

/* actions menu */
.menu {
top: 47px;
Expand Down
9 changes: 7 additions & 2 deletions core/src/OC/contactsmenu/contact.handlebars
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,13 @@
<div class="email-address">{{contact.emailAddresses}}</div>
</a>
{{/if}}
{{#if contact.topAction}}
<a class="top-action" href="{{contact.topAction.hyperlink}}" title="{{contact.topAction.title}}">
<img src="{{contact.topAction.icon}}" alt="{{contact.topAction.title}}">
</a>
{{/if}}
{{else if contact.topAction}}
<a class="body" href="{{contact.topAction.hyperlink}}">
<a class="body" href="{{contact.topAction.hyperlink}}">
<div class="full-name">{{contact.fullName}}</div>
<div class="last-message">{{contact.lastMessage}}</div>
<div class="email-address">{{contact.emailAddresses}}</div>
Expand All @@ -49,7 +54,7 @@
</a>
{{/if}}
{{#if contact.hasManyActions}}
<span class="other-actions icon-more"></span>
<button class="other-actions icon-more"></button>
<div class="menu popovermenu">
<ul>
{{#each contact.actions}}
Expand Down
4 changes: 2 additions & 2 deletions dist/core-login.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/core-login.js.map
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions dist/core-main.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/core-main.js.map
View file
Open in desktop

Large diffs are not rendered by default.