Skip to content

Improve frontend-building related Makefile rules #32753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
StCyr wants to merge 2 commits into from
Closed

Improve frontend-building related Makefile rules #32753

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
135c698
Updates frontend-building related Makefile rules to also create
StCyr Jun 8, 2022
f554c33
Add postbuild step
PVince81 Jul 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Updates frontend-building related Makefile rules to also create 
the dist/icons.css file.
Updates the core/src/icons.js script to allow it to run before
'npm run dev', 'npm run build', or 'npm run watch' is run.

Signed-off-by: Cyrille Bollu <[email protected]>
  • Loading branch information
@StCyr @PVince81
StCyr authored and PVince81 committed Jul 22, 2022
commit 135c6986e1bda5d0fe91fcee20a22333d25ad231
10 changes: 7 additions & 3 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,18 @@ npm-update:
npm update

# Building
build-js:
build-js: build-css
npm run dev

build-js-production:
npm run build

watch-js:
npm run watch
watch-js: build-css
npm run watch &
npm run sass:watch

build-css:
npm run sass:icons

# Linting
lint-fix:
Expand Down
1 change: 1 addition & 0 deletions core/src/icons.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,4 +332,5 @@ css += generateVariablesAliases(true)
css += '}'

// WRITE CSS
fs.mkdir('dist', (err) => { if (err) { console.info('Directory dist/ already exists') } })
fs.writeFileSync(path.join(__dirname, '../../dist', 'icons.css'), sass.compileString(css).css)