Skip to content

Conversation

@kesselb
Copy link
Contributor

@kesselb kesselb commented Jun 8, 2022

Fix #32749

To allow a search query like in:mail test

Some samples for testing:

in:files test
test in:files
 in:files test
-in:files test
 -in:files test
test -in:files
within files
data-in: test

@kesselb kesselb added enhancement 3. to review Waiting for reviews labels Jun 8, 2022
@kesselb kesselb requested review from a team, artonge, skjnldsv and szaimen and removed request for a team June 8, 2022 17:52
@kesselb kesselb force-pushed the enh/32749/regex-universal-search branch from 676977e to 78786a2 Compare June 8, 2022 17:56
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks a lot!

I hope some day we can do it with a tokenizer of sorts

@PVince81 PVince81 merged commit e56a072 into master Jun 9, 2022
@PVince81 PVince81 deleted the enh/32749/regex-universal-search branch June 9, 2022 10:04
@PVince81
Copy link
Member

this caused a regression because it adds a new capturing group

fix is here: #34614

@PVince81 PVince81 added this to the Nextcloud 25 milestone Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: "in:files" statement in search field only returns emails (and not files :/)

4 participants