Skip to content

Only resize an image if it results in a smaller image size #32787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jcjveraa wants to merge 3 commits into from
Closed

Only resize an image if it results in a smaller image size #32787

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
48eb65e
Only resize an image if it results in a smaller image size
jcjveraa Jun 9, 2022
c9f94dd
Fix docstring
jcjveraa Jun 9, 2022
8b7afdb
Retain file type but ensure 'progressive' image
jcjveraa Jun 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix docstring 
Docstring was copy-pasted and not updated.

Signed-off-by: JelleV <[email protected]>
  • Loading branch information
@jcjveraa
jcjveraa committed Jun 9, 2022
commit c9f94ddafaa05402f5d77ae45c3013ff9d4ad2b4
2 changes: 1 addition & 1 deletion apps/theming/lib/ImageManager.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ public function updateImage(string $key, string $tmpFile): string {
* a maximum of 4096 pixels wide (preserving aspect ratio), but only if the resizing
* results in an image that has a smaller file size than the uploaded file.
*
* @param string $originalTmpFile The image key, e.g. "favicon"
* @param string $originalTmpFile The tmpFile(path) as uploaded by the user
* @return string Location of the resized file, or the original
*/
private function getResizedImagePathIfResizeIsSmaller(string $originalTmpFile): string
Expand Down