Use single stream to validate custom dashboard image #32817
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christopher Ng <[email protected]>
Pytal
requested review from
come-nc and
icewind1991
and removed request for
a team
PVince81
reviewed
Jun 13, 2022
| throw new InvalidArgumentException('Invalid image file'); | ||
| } | ||
| $this->getAppDataFolder()->newFile('background.jpg', $file->fopen('r')); | ||
| rewind($stream); |
Member
There was a problem hiding this comment.
this needs to be tested with object store, rewind might not work on all stream types (not sure if a http stream can be rewinded)
now thinking again, I see that this endpoint is only for setting a background image, something that will not happen repeatedly, so having a little performance impact here for validation is probably ok
feel free to revert back to the former solution and sorry for the noise
Member
Author
|
Closing as per #32817 (comment) |
Member
Author
|
The cherry-picked commit from this PR has also been removed from the following backports |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Amendment to #32675 as per #32791 (review)
This has been cherry-picked onto the existing backports of #32675