Skip to content

Conversation

@CarlSchwan
Copy link
Member

The cookie value contains invalid utf8 characters most of the time so
let's just ignore it as it is also not that interesting to analyse.

@CarlSchwan CarlSchwan added the 3. to review Waiting for reviews label Jun 17, 2022
@CarlSchwan CarlSchwan added this to the Nextcloud 25 milestone Jun 17, 2022
@CarlSchwan CarlSchwan requested review from a team, blizzz and icewind1991 June 17, 2022 08:25
@CarlSchwan CarlSchwan self-assigned this Jun 17, 2022
@CarlSchwan CarlSchwan requested review from come-nc and removed request for a team June 17, 2022 08:25
@CarlSchwan
Copy link
Member Author

/backport to stable24

@blizzz
Copy link
Member

blizzz commented Jun 17, 2022

The cookie is to be treated as an opaque structure by RFC. It is only created and interpreted by the server implementation. On client side the job is only passing it forth and back with the requests. A mechanism to keep track/state on the LDAP server.

The cookie value contains invalid utf8 characters most of the time so
let's just ignore it as it is also not that interesting to analyse.

Signed-off-by: Carl Schwan <[email protected]>
@CarlSchwan CarlSchwan force-pushed the fix/profiler-invalid-utf8 branch from bdc811d to 35d8bdc Compare June 20, 2022 09:11
@blizzz blizzz merged commit a94de5c into master Jun 20, 2022
@blizzz blizzz deleted the fix/profiler-invalid-utf8 branch June 20, 2022 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants